Add branded macOS installer welcome and background#79
Closed
RenanGBarreto wants to merge 8 commits into
Closed
Conversation
Code Coverage OverviewLanguages: Python Python / code-coverage/pytestThe overall coverage remains at 75%, unchanged from the branch. Updated |
… resource listing
…oid hidden package issue
…fail on tiny product; diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add branded macOS installer welcome and background
🤔 Why?
🔧 What changed
assets/installer/distribution.xml(installer manifest used byproductbuild) with an__ART_VERSION__placeholder.assets/installer/Welcome.rtf; CI injects the real version into this file during the build.scripts/gen_installer_background.pyto generate a simple polished background image and producedassets/images/installer-background.png..github/workflows/ci.ymlto embed the.icnsinto the app bundle, copy installer resources fromassets/, substituteART_VERSIONinto the manifest and welcome RTF, and callproductbuild --distributionso the installer UI shows the title, background, and welcome.Applications/MkPFS.app/Contents/Resources/VERSION.txtwith the installed version.🧪 How to test
.pkg..pkg: the installer title should readMkPFS <version>and show the welcome screen and background./Applications/MkPFS.app/Contents/Resources/VERSION.txtfor the version string.💬 Notes for reviewers
Closes: none